change: Make jwt-aud config value a regular expression #4397
+93
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleczek
force-pushed
the
aud-regex
branch
2 times, most recently
from
ea4b9f1 to
2895007
Compare
mkleczek
changed the title
mkleczek
force-pushed
the
aud-regex
branch
3 times, most recently
from
43c8f07 to
153080a
Compare
taimoorzaeem
added
the
breaking change
|
@mkleczek Could you add a summary of the PR? From reading the issues I'm not sure what's the final design here. This would make it easier to review. Also, is the breaking change avoidable by changing the default configuration? |
* Introduced StringOrURI newtype and its validating FromJSON implementation in Auth.JWT * Changed JwtError constructor AudClaimNotStringOrArray to AudClaimNotStringOrURIOrArray and modified error message for it * Added test in AuthSpec * Modified tests to verify new error message Left validation of URI in jwt-aud as is.
This change adds flexibility to aud claim validation. jwt-aud configuration property can now be specified as a regular expression. For example, it is now possible to * configure multiple acceptable aud values with '|' regex operator, eg: 'audience1|audience2|audience3' * accept any audience from a particular domain, eg: 'https://[a-z0-9]*\.example\.com'
Done.
Yes. I've decided to set default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds flexibility to aud claim validation. jwt-aud configuration property can now be specified as a regular expression. For example, it is now possible to
Resolves #2099